SolarXR IPC Socket #1247
Merged
SolarXR IPC Socket #1247
+334
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: SteamVR Driver
|
Marked as draft since I'm not sure I have |
Eirenliel
approved these changes
Dec 11, 2024
|
This looks fine, i think it should be ready for review and rebased. The details like try/catch could be found on review and testing. |
|
alright |
server/core/src/main/java/dev/slimevr/protocol/ProtocolAPI.java
Outdated
Show resolved
Hide resolved
ImUrX
reviewed
Dec 21, 2024
rcelyte
force-pushed
the
solarxr-ipc
branch
2 times, most recently
from
ef8ff74 to
cf6aac9
Compare
rcelyte
force-pushed
the
solarxr-ipc
branch
2 times, most recently
from
111b37c to
f1e2e88
Compare
Eirenliel
approved these changes
Jan 3, 2025
ButterscotchV
approved these changes
Jan 14, 2025
server/desktop/src/main/java/dev/slimevr/desktop/platform/linux/UnixSocketConnection.java
Outdated
Show resolved
Hide resolved
ImUrX
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces an IPC interface for communicating with the server via SolarXR ー exposing bone data not available through the existing Protobuf API while remaining more reliable and performant compared to the WebSocket API. Monado will require this interface to implement XR_FB_body_tracking while maintaining latency parity with the OpenVR driver (see https://gitlab.freedesktop.org/monado/monado/-/merge_requests/2253).
It also fixes a one line bug in the WebSocket API where messages got clobbered on send, resulting in all but the first SolarXR connection receiving mangled data.